~cytrogen/masto-fe

0c1b1069c96d3452d43d922a737c522d10e4747b — Eugen Rochko 6 years ago 30f5bcf
Remove deprecated REST API `GET /api/v1/statuses/:id/card` (#11213)

M app/controllers/api/v1/statuses_controller.rb => app/controllers/api/v1/statuses_controller.rb +2 -12
@@ 5,8 5,8 @@ class Api::V1::StatusesController < Api::BaseController

  before_action -> { authorize_if_got_token! :read, :'read:statuses' }, except: [:create, :destroy]
  before_action -> { doorkeeper_authorize! :write, :'write:statuses' }, only:   [:create, :destroy]
  before_action :require_user!, except:  [:show, :context, :card]
  before_action :set_status, only:       [:show, :context, :card]
  before_action :require_user!, except:  [:show, :context]
  before_action :set_status, only:       [:show, :context]

  respond_to :json



@@ 33,16 33,6 @@ class Api::V1::StatusesController < Api::BaseController
    render json: @context, serializer: REST::ContextSerializer, relationships: StatusRelationshipsPresenter.new(statuses, current_user&.account_id)
  end

  def card
    @card = @status.preview_cards.first

    if @card.nil?
      render_empty
    else
      render json: @card, serializer: REST::PreviewCardSerializer
    end
  end

  def create
    @status = PostStatusService.new.call(current_user.account,
                                         text: status_params[:status],

M config/routes.rb => config/routes.rb +0 -1
@@ 294,7 294,6 @@ Rails.application.routes.draw do

        member do
          get :context
          get :card
        end
      end


M spec/controllers/api/v1/statuses_controller_spec.rb => spec/controllers/api/v1/statuses_controller_spec.rb +0 -14
@@ 91,13 91,6 @@ RSpec.describe Api::V1::StatusesController, type: :controller do
          expect(response).to have_http_status(404)
        end
      end

      describe 'GET #card' do
        it 'returns http unautharized' do
          get :card, params: { id: status.id }
          expect(response).to have_http_status(404)
        end
      end
    end

    context 'with a public status' do


@@ 120,13 113,6 @@ RSpec.describe Api::V1::StatusesController, type: :controller do
          expect(response).to have_http_status(200)
        end
      end

      describe 'GET #card' do
        it 'returns http success' do
          get :card, params: { id: status.id }
          expect(response).to have_http_status(200)
        end
      end
    end
  end
end