~cytrogen/masto-fe

0ccf6c0eb73f612f1e727bac64dddea62b296e30 — Claire 2 years ago 9caa047
Fix batch attachment deletion leaving empty directories (#25587)

1 files changed, 9 insertions(+), 1 deletions(-)

M app/lib/attachment_batch.rb
M app/lib/attachment_batch.rb => app/lib/attachment_batch.rb +9 -1
@@ 64,7 64,15 @@ class AttachmentBatch
            keys << attachment.style_name_as_path(style)
          when :filesystem
            logger.debug { "Deleting #{attachment.path(style)}" }
            FileUtils.remove_file(attachment.path(style), true)
            path = attachment.path(style)
            FileUtils.remove_file(path, true)

            begin
              FileUtils.rmdir(File.dirname(path), parents: true)
            rescue Errno::EEXIST, Errno::ENOTEMPTY, Errno::ENOENT, Errno::EINVAL, Errno::ENOTDIR, Errno::EACCES
              # Ignore failure to delete a directory, with the same ignored errors
              # as Paperclip
            end
          when :fog
            logger.debug { "Deleting #{attachment.path(style)}" }
            attachment.directory.files.new(key: attachment.path(style)).destroy