~cytrogen/masto-fe

38433ccd0bb9a47c9882e64d4644f7c5b47858b3 — Matt Jankowski 2 years ago 602c458
Reduce `Admin::Reports::Actions` spec db activity (#25465)

1 files changed, 12 insertions(+), 18 deletions(-)

M spec/controllers/admin/reports/actions_controller_spec.rb
M spec/controllers/admin/reports/actions_controller_spec.rb => spec/controllers/admin/reports/actions_controller_spec.rb +12 -18
@@ 62,17 62,10 @@ describe Admin::Reports::ActionsController do
    end

    shared_examples 'common behavior' do
      it 'closes the report' do
        expect { subject }.to change { report.reload.action_taken? }.from(false).to(true)
      end
      it 'closes the report and redirects' do
        expect { subject }.to mark_report_action_taken.and create_target_account_strike

      it 'creates a strike with the expected text' do
        expect { subject }.to change { report.target_account.strikes.count }.by(1)
        expect(report.target_account.strikes.last.text).to eq text
      end

      it 'redirects' do
        subject
        expect(response).to redirect_to(admin_reports_path)
      end



@@ 81,20 74,21 @@ describe Admin::Reports::ActionsController do
          { report_id: report.id }
        end

        it 'closes the report' do
          expect { subject }.to change { report.reload.action_taken? }.from(false).to(true)
        end
        it 'closes the report and redirects' do
          expect { subject }.to mark_report_action_taken.and create_target_account_strike

        it 'creates a strike with the expected text' do
          expect { subject }.to change { report.target_account.strikes.count }.by(1)
          expect(report.target_account.strikes.last.text).to eq ''
        end

        it 'redirects' do
          subject
          expect(response).to redirect_to(admin_reports_path)
        end
      end

      def mark_report_action_taken
        change { report.reload.action_taken? }.from(false).to(true)
      end

      def create_target_account_strike
        change { report.target_account.strikes.count }.by(1)
      end
    end

    shared_examples 'all action types' do