~cytrogen/masto-fe

3a2a15c6ea4d4603469861ed9be09da12a122e45 — Matt Jankowski 2 years ago c94bb9b
Use `build` where possible in fabricators (#25360)

41 files changed, 58 insertions(+), 58 deletions(-)

M spec/fabricators/account_domain_block_fabricator.rb
M spec/fabricators/account_moderation_note_fabricator.rb
M spec/fabricators/account_note_fabricator.rb
M spec/fabricators/account_stat_fabricator.rb
M spec/fabricators/account_statuses_cleanup_policy_fabricator.rb
M spec/fabricators/account_warning_fabricator.rb
M spec/fabricators/admin_action_log_fabricator.rb
M spec/fabricators/backup_fabricator.rb
M spec/fabricators/block_fabricator.rb
M spec/fabricators/bookmark_fabricator.rb
M spec/fabricators/bulk_import_fabricator.rb
M spec/fabricators/bulk_import_row_fabricator.rb
M spec/fabricators/canonical_email_block_fabricator.rb
M spec/fabricators/custom_filter_fabricator.rb
M spec/fabricators/custom_filter_keyword_fabricator.rb
M spec/fabricators/custom_filter_status_fabricator.rb
M spec/fabricators/device_fabricator.rb
M spec/fabricators/encrypted_message_fabricator.rb
M spec/fabricators/favourite_fabricator.rb
M spec/fabricators/featured_tag_fabricator.rb
M spec/fabricators/follow_fabricator.rb
M spec/fabricators/follow_request_fabricator.rb
M spec/fabricators/identity_fabricator.rb
M spec/fabricators/invite_fabricator.rb
M spec/fabricators/list_fabricator.rb
M spec/fabricators/login_activity_fabricator.rb
M spec/fabricators/marker_fabricator.rb
M spec/fabricators/media_attachment_fabricator.rb
M spec/fabricators/mention_fabricator.rb
M spec/fabricators/mute_fabricator.rb
M spec/fabricators/notification_fabricator.rb
M spec/fabricators/one_time_key_fabricator.rb
M spec/fabricators/poll_fabricator.rb
M spec/fabricators/poll_vote_fabricator.rb
M spec/fabricators/report_fabricator.rb
M spec/fabricators/report_note_fabricator.rb
M spec/fabricators/scheduled_status_fabricator.rb
M spec/fabricators/session_activation_fabricator.rb
M spec/fabricators/status_fabricator.rb
M spec/fabricators/status_pin_fabricator.rb
M spec/fabricators/tag_follow_fabricator.rb
M spec/fabricators/account_domain_block_fabricator.rb => spec/fabricators/account_domain_block_fabricator.rb +1 -1
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:account_domain_block) do
  account
  account { Fabricate.build(:account) }
  domain 'example.com'
end

M spec/fabricators/account_moderation_note_fabricator.rb => spec/fabricators/account_moderation_note_fabricator.rb +2 -2
@@ 2,6 2,6 @@

Fabricator(:account_moderation_note) do
  content 'MyText'
  account
  target_account { Fabricate(:account) }
  account { Fabricate.build(:account) }
  target_account { Fabricate.build(:account) }
end

M spec/fabricators/account_note_fabricator.rb => spec/fabricators/account_note_fabricator.rb +2 -2
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:account_note) do
  account
  target_account { Fabricate(:account) }
  account { Fabricate.build(:account) }
  target_account { Fabricate.build(:account) }
  comment        'User note text'
end

M spec/fabricators/account_stat_fabricator.rb => spec/fabricators/account_stat_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:account_stat) do
  account
  account { Fabricate.build(:account) }
  statuses_count  '123'
  following_count '456'
  followers_count '789'

M spec/fabricators/account_statuses_cleanup_policy_fabricator.rb => spec/fabricators/account_statuses_cleanup_policy_fabricator.rb +1 -1
@@ 1,5 1,5 @@
# frozen_string_literal: true

Fabricator(:account_statuses_cleanup_policy) do
  account
  account { Fabricate.build(:account) }
end

M spec/fabricators/account_warning_fabricator.rb => spec/fabricators/account_warning_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:account_warning) do
  account
  account { Fabricate.build(:account) }
  target_account(fabricator: :account)
  text { Faker::Lorem.paragraph }
  action 'suspend'

M spec/fabricators/admin_action_log_fabricator.rb => spec/fabricators/admin_action_log_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator('Admin::ActionLog') do
  account
  account { Fabricate.build(:account) }
  action  'MyString'
  target  nil
end

M spec/fabricators/backup_fabricator.rb => spec/fabricators/backup_fabricator.rb +1 -1
@@ 1,5 1,5 @@
# frozen_string_literal: true

Fabricator(:backup) do
  user
  user { Fabricate.build(:user) }
end

M spec/fabricators/block_fabricator.rb => spec/fabricators/block_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:block) do
  account
  target_account { Fabricate(:account) }
  account { Fabricate.build(:account) }
  target_account { Fabricate.build(:account) }
end

M spec/fabricators/bookmark_fabricator.rb => spec/fabricators/bookmark_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:bookmark) do
  account
  status
  account { Fabricate.build(:account) }
  status { Fabricate.build(:status) }
end

M spec/fabricators/bulk_import_fabricator.rb => spec/fabricators/bulk_import_fabricator.rb +1 -1
@@ 8,5 8,5 @@ Fabricator(:bulk_import) do
  imported_items  1
  finished_at     '2022-11-18 14:55:07'
  overwrite       false
  account
  account { Fabricate.build(:account) }
end

M spec/fabricators/bulk_import_row_fabricator.rb => spec/fabricators/bulk_import_row_fabricator.rb +1 -1
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:bulk_import_row) do
  bulk_import
  bulk_import { Fabricate.build(:bulk_import) }
  data ''
end

M spec/fabricators/canonical_email_block_fabricator.rb => spec/fabricators/canonical_email_block_fabricator.rb +1 -1
@@ 2,5 2,5 @@

Fabricator(:canonical_email_block) do
  email { sequence(:email) { |i| "#{i}#{Faker::Internet.email}" } }
  reference_account { Fabricate(:account) }
  reference_account { Fabricate.build(:account) }
end

M spec/fabricators/custom_filter_fabricator.rb => spec/fabricators/custom_filter_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:custom_filter) do
  account
  account { Fabricate.build(:account) }
  expires_at nil
  phrase     'discourse'
  context    %w(home notifications)

M spec/fabricators/custom_filter_keyword_fabricator.rb => spec/fabricators/custom_filter_keyword_fabricator.rb +1 -1
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:custom_filter_keyword) do
  custom_filter
  custom_filter { Fabricate.build(:custom_filter) }
  keyword 'discourse'
end

M spec/fabricators/custom_filter_status_fabricator.rb => spec/fabricators/custom_filter_status_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:custom_filter_status) do
  custom_filter
  status
  custom_filter { Fabricate.build(:custom_filter) }
  status { Fabricate.build(:status) }
end

M spec/fabricators/device_fabricator.rb => spec/fabricators/device_fabricator.rb +2 -2
@@ 1,8 1,8 @@
# frozen_string_literal: true

Fabricator(:device) do
  access_token
  account
  access_token { Fabricate.build(:access_token) }
  account { Fabricate.build(:account) }
  device_id        { Faker::Number.number(digits: 5) }
  name             { Faker::App.name }
  fingerprint_key  { Base64.strict_encode64(Ed25519::SigningKey.generate.verify_key.to_bytes) }

M spec/fabricators/encrypted_message_fabricator.rb => spec/fabricators/encrypted_message_fabricator.rb +2 -2
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:encrypted_message) do
  device
  from_account { Fabricate(:account) }
  device { Fabricate.build(:device) }
  from_account { Fabricate.build(:account) }
  from_device_id { Faker::Number.number(digits: 5) }
end

M spec/fabricators/favourite_fabricator.rb => spec/fabricators/favourite_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:favourite) do
  account
  status
  account { Fabricate.build(:account) }
  status { Fabricate.build(:status) }
end

M spec/fabricators/featured_tag_fabricator.rb => spec/fabricators/featured_tag_fabricator.rb +2 -2
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:featured_tag) do
  account
  tag
  account { Fabricate.build(:account) }
  tag { Fabricate.build(:tag) }
  name { sequence(:name) { |i| "Tag#{i}" } }
end

M spec/fabricators/follow_fabricator.rb => spec/fabricators/follow_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:follow) do
  account
  target_account { Fabricate(:account) }
  account { Fabricate.build(:account) }
  target_account { Fabricate.build(:account) }
end

M spec/fabricators/follow_request_fabricator.rb => spec/fabricators/follow_request_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:follow_request) do
  account
  target_account { Fabricate(:account, locked: true) }
  account { Fabricate.build(:account) }
  target_account { Fabricate.build(:account, locked: true) }
end

M spec/fabricators/identity_fabricator.rb => spec/fabricators/identity_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:identity) do
  user
  user { Fabricate.build(:user) }
  provider 'MyString'
  uid      'MyString'
end

M spec/fabricators/invite_fabricator.rb => spec/fabricators/invite_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:invite) do
  user
  user { Fabricate.build(:user) }
  expires_at nil
  max_uses   nil
  uses       0

M spec/fabricators/list_fabricator.rb => spec/fabricators/list_fabricator.rb +1 -1
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:list) do
  account
  account { Fabricate.build(:account) }
  title 'MyString'
end

M spec/fabricators/login_activity_fabricator.rb => spec/fabricators/login_activity_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:login_activity) do
  user
  user { Fabricate.build(:user) }
  authentication_method 'password'
  success               true
  failure_reason        nil

M spec/fabricators/marker_fabricator.rb => spec/fabricators/marker_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:marker) do
  user
  user { Fabricate.build(:user) }
  timeline     'home'
  last_read_id 0
  lock_version 0

M spec/fabricators/media_attachment_fabricator.rb => spec/fabricators/media_attachment_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:media_attachment) do
  account
  account { Fabricate.build(:account) }

  file do |attrs|
    case attrs[:type]

M spec/fabricators/mention_fabricator.rb => spec/fabricators/mention_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:mention) do
  account
  status
  account { Fabricate.build(:account) }
  status { Fabricate.build(:status) }
end

M spec/fabricators/mute_fabricator.rb => spec/fabricators/mute_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:mute) do
  account
  target_account { Fabricate(:account) }
  account { Fabricate.build(:account) }
  target_account { Fabricate.build(:account) }
end

M spec/fabricators/notification_fabricator.rb => spec/fabricators/notification_fabricator.rb +1 -1
@@ 2,5 2,5 @@

Fabricator(:notification) do
  activity fabricator: :status
  account
  account { Fabricate.build(:account) }
end

M spec/fabricators/one_time_key_fabricator.rb => spec/fabricators/one_time_key_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:one_time_key) do
  device
  device { Fabricate.build(:device) }
  key_id { Faker::Alphanumeric.alphanumeric(number: 10) }
  key { Base64.strict_encode64(Ed25519::SigningKey.generate.verify_key.to_bytes) }


M spec/fabricators/poll_fabricator.rb => spec/fabricators/poll_fabricator.rb +2 -2
@@ 1,8 1,8 @@
# frozen_string_literal: true

Fabricator(:poll) do
  account
  status
  account { Fabricate.build(:account) }
  status { Fabricate.build(:status) }
  expires_at  { 7.days.from_now }
  options     %w(Foo Bar)
  multiple    false

M spec/fabricators/poll_vote_fabricator.rb => spec/fabricators/poll_vote_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:poll_vote) do
  account
  account { Fabricate.build(:account) }
  poll
  choice 0
end

M spec/fabricators/report_fabricator.rb => spec/fabricators/report_fabricator.rb +2 -2
@@ 1,8 1,8 @@
# frozen_string_literal: true

Fabricator(:report) do
  account
  target_account  { Fabricate(:account) }
  account { Fabricate.build(:account) }
  target_account  { Fabricate.build(:account) }
  comment         'You nasty'
  action_taken_at nil
end

M spec/fabricators/report_note_fabricator.rb => spec/fabricators/report_note_fabricator.rb +2 -2
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:report_note) do
  report
  account { Fabricate(:account) }
  report { Fabricate.build(:report) }
  account { Fabricate.build(:account) }
  content 'Test Content'
end

M spec/fabricators/scheduled_status_fabricator.rb => spec/fabricators/scheduled_status_fabricator.rb +1 -1
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:scheduled_status) do
  account
  account { Fabricate.build(:account) }
  scheduled_at { 20.hours.from_now }
end

M spec/fabricators/session_activation_fabricator.rb => spec/fabricators/session_activation_fabricator.rb +1 -1
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:session_activation) do
  user
  user { Fabricate.build(:user) }
  session_id 'MyString'
end

M spec/fabricators/status_fabricator.rb => spec/fabricators/status_fabricator.rb +1 -1
@@ 1,7 1,7 @@
# frozen_string_literal: true

Fabricator(:status) do
  account
  account { Fabricate.build(:account) }
  text 'Lorem ipsum dolor sit amet'

  after_build do |status|

M spec/fabricators/status_pin_fabricator.rb => spec/fabricators/status_pin_fabricator.rb +2 -2
@@ 1,6 1,6 @@
# frozen_string_literal: true

Fabricator(:status_pin) do
  account
  status { |attrs| Fabricate(:status, account: attrs[:account], visibility: :public) }
  account { Fabricate.build(:account) }
  status { |attrs| Fabricate.build(:status, account: attrs[:account], visibility: :public) }
end

M spec/fabricators/tag_follow_fabricator.rb => spec/fabricators/tag_follow_fabricator.rb +1 -1
@@ 2,5 2,5 @@

Fabricator(:tag_follow) do
  tag
  account
  account { Fabricate.build(:account) }
end