~cytrogen/masto-fe

5cd55d8aaf9880ca36dfa16d08600d31e8a5ff17 — Claire 2 years ago bec6a1c
Fix being able to vote on your own polls (#25015)

2 files changed, 6 insertions(+), 1 deletions(-)

M app/validators/vote_validator.rb
M config/locales/en.yml
M app/validators/vote_validator.rb => app/validators/vote_validator.rb +5 -1
@@ 3,8 3,8 @@
class VoteValidator < ActiveModel::Validator
  def validate(vote)
    vote.errors.add(:base, I18n.t('polls.errors.expired')) if vote.poll_expired?

    vote.errors.add(:base, I18n.t('polls.errors.invalid_choice')) if invalid_choice?(vote)
    vote.errors.add(:base, I18n.t('polls.errors.self_vote')) if self_vote?(vote)

    vote.errors.add(:base, I18n.t('polls.errors.already_voted')) if additional_voting_not_allowed?(vote)
  end


@@ 27,6 27,10 @@ class VoteValidator < ActiveModel::Validator
    vote.choice.negative? || vote.choice >= vote.poll.options.size
  end

  def self_vote?(vote)
    vote.account_id == vote.poll.account_id
  end

  def already_voted_for_same_choice_on_multiple_poll?(vote)
    if vote.persisted?
      account_votes_on_same_poll(vote).where(choice: vote.choice).where.not(poll_votes: { id: vote }).exists?

M config/locales/en.yml => config/locales/en.yml +1 -0
@@ 1446,6 1446,7 @@ en:
      expired: The poll has already ended
      invalid_choice: The chosen vote option does not exist
      over_character_limit: cannot be longer than %{max} characters each
      self_vote: You cannot vote in your own polls
      too_few_options: must have more than one item
      too_many_options: can't contain more than %{max} items
  preferences: