~cytrogen/masto-fe

5e060e1f447d91436c18e164c4d32054a9a72d5f — Matt Jankowski 2 years ago 41eb49b
Fix Performance/Sum cop (#24788)

M .rubocop_todo.yml => .rubocop_todo.yml +0 -8
@@ 372,14 372,6 @@ Performance/StartWith:
    - 'app/lib/extractor.rb'

# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: OnlySumOrWithInitialValue.
Performance/Sum:
  Exclude:
    - 'app/lib/activity_tracker.rb'
    - 'app/models/trends/history.rb'
    - 'lib/paperclip/color_extractor.rb'

# This cop supports unsafe autocorrection (--autocorrect-all).
Performance/TimesMap:
  Exclude:
    - 'spec/controllers/api/v1/blocks_controller_spec.rb'

M app/lib/activity_tracker.rb => app/lib/activity_tracker.rb +1 -1
@@ 43,7 43,7 @@ class ActivityTracker

    case @type
    when :basic
      redis.mget(*keys).map(&:to_i).sum
      redis.mget(*keys).sum(&:to_i)
    when :unique
      redis.pfcount(*keys)
    end

M app/models/trends/history.rb => app/models/trends/history.rb +1 -1
@@ 11,7 11,7 @@ class Trends::History
    end

    def uses
      with_redis { |redis| redis.mget(*@days.map { |day| day.key_for(:uses) }).map(&:to_i).sum }
      with_redis { |redis| redis.mget(*@days.map { |day| day.key_for(:uses) }).sum(&:to_i) }
    end

    def accounts

M lib/paperclip/color_extractor.rb => lib/paperclip/color_extractor.rb +1 -1
@@ 173,7 173,7 @@ module Paperclip
    def palette_from_histogram(result, quantity)
      frequencies       = result.scan(/([0-9]+)\:/).flatten.map(&:to_f)
      hex_values        = result.scan(/\#([0-9A-Fa-f]{6,8})/).flatten
      total_frequencies = frequencies.reduce(&:+).to_f
      total_frequencies = frequencies.sum.to_f

      frequencies.map.with_index { |f, i| [f / total_frequencies, hex_values[i]] }
                 .sort_by { |r| -r[0] }