~cytrogen/masto-fe

c8ba75b963e7a3e2c7ae0a3a3723686e7ea1bd37 — Thibaut Girka 6 years ago 6ad870a + ca89447
Merge branch 'master' into glitch-soc/merge-upstream
M app/javascript/mastodon/actions/search.js => app/javascript/mastodon/actions/search.js +3 -2
@@ 48,7 48,7 @@ export function submitSearch() {
        dispatch(importFetchedStatuses(response.data.statuses));
      }

      dispatch(fetchSearchSuccess(response.data));
      dispatch(fetchSearchSuccess(response.data, value));
      dispatch(fetchRelationships(response.data.accounts.map(item => item.id)));
    }).catch(error => {
      dispatch(fetchSearchFail(error));


@@ 62,10 62,11 @@ export function fetchSearchRequest() {
  };
};

export function fetchSearchSuccess(results) {
export function fetchSearchSuccess(results, searchTerm) {
  return {
    type: SEARCH_FETCH_SUCCESS,
    results,
    searchTerm,
  };
};


M app/javascript/mastodon/features/compose/components/search_results.js => app/javascript/mastodon/features/compose/components/search_results.js +13 -1
@@ 7,6 7,7 @@ import StatusContainer from '../../../containers/status_container';
import ImmutablePureComponent from 'react-immutable-pure-component';
import Hashtag from '../../../components/hashtag';
import Icon from 'mastodon/components/icon';
import { searchEnabled } from '../../../initial_state';

const messages = defineMessages({
  dismissSuggestion: { id: 'suggestions.dismiss', defaultMessage: 'Dismiss suggestion' },


@@ 20,6 21,7 @@ class SearchResults extends ImmutablePureComponent {
    suggestions: ImmutablePropTypes.list.isRequired,
    fetchSuggestions: PropTypes.func.isRequired,
    dismissSuggestion: PropTypes.func.isRequired,
    searchTerm: PropTypes.string,
    intl: PropTypes.object.isRequired,
  };



@@ 28,7 30,7 @@ class SearchResults extends ImmutablePureComponent {
  }

  render () {
    const { intl, results, suggestions, dismissSuggestion } = this.props;
    const { intl, results, suggestions, dismissSuggestion, searchTerm } = this.props;

    if (results.isEmpty() && !suggestions.isEmpty()) {
      return (


@@ 76,6 78,16 @@ class SearchResults extends ImmutablePureComponent {
          {results.get('statuses').map(statusId => <StatusContainer key={statusId} id={statusId} />)}
        </div>
      );
    } else if(results.get('statuses') && results.get('statuses').size === 0 && !searchEnabled && !(searchTerm.startsWith('@') || searchTerm.startsWith('#') || searchTerm.includes(' '))) {
      statuses = (
        <div className='search-results__section'>
          <h5><Icon id='quote-right' fixedWidth /><FormattedMessage id='search_results.statuses' defaultMessage='Toots' /></h5>

          <div className='search-results__info'>
            <FormattedMessage id='search_results.statuses_fts_disabled' defaultMessage='Searching toots by their content is not enabled on this Mastodon server.' />
          </div>
        </div>
      );
    }

    if (results.get('hashtags') && results.get('hashtags').size > 0) {

M app/javascript/mastodon/features/compose/containers/search_results_container.js => app/javascript/mastodon/features/compose/containers/search_results_container.js +1 -0
@@ 5,6 5,7 @@ import { fetchSuggestions, dismissSuggestion } from '../../../actions/suggestion
const mapStateToProps = state => ({
  results: state.getIn(['search', 'results']),
  suggestions: state.getIn(['suggestions', 'items']),
  searchTerm: state.getIn(['search', 'value']),
});

const mapDispatchToProps = dispatch => ({

M app/javascript/mastodon/reducers/search.js => app/javascript/mastodon/reducers/search.js +2 -1
@@ 16,6 16,7 @@ const initialState = ImmutableMap({
  submitted: false,
  hidden: false,
  results: ImmutableMap(),
  searchTerm: '',
});

export default function search(state = initialState, action) {


@@ 40,7 41,7 @@ export default function search(state = initialState, action) {
      accounts: ImmutableList(action.results.accounts.map(item => item.id)),
      statuses: ImmutableList(action.results.statuses.map(item => item.id)),
      hashtags: fromJS(action.results.hashtags),
    })).set('submitted', true);
    })).set('submitted', true).set('searchTerm', action.searchTerm);
  default:
    return state;
  }

M app/javascript/styles/mastodon/components.scss => app/javascript/styles/mastodon/components.scss +5 -0
@@ 3996,6 3996,11 @@ a.status-card.compact:hover {
  }
}

.search-results__info {
  padding: 10px;
  color: $secondary-text-color;
}

.modal-root {
  position: relative;
  transition: opacity 0.3s linear;

M app/serializers/activitypub/update_poll_serializer.rb => app/serializers/activitypub/update_poll_serializer.rb +1 -1
@@ 14,7 14,7 @@ class ActivityPub::UpdatePollSerializer < ActivityPub::Serializer
  end

  def actor
    ActivityPub::TagManager.instance.uri_for(object)
    ActivityPub::TagManager.instance.uri_for(object.account)
  end

  def to

A spec/serializers/activitypub/update_poll_spec.rb => spec/serializers/activitypub/update_poll_spec.rb +27 -0
@@ 0,0 1,27 @@
# frozen_string_literal: true

require 'rails_helper'

describe ActivityPub::UpdatePollSerializer do
  let(:account) { Fabricate(:account) }
  let(:poll)    { Fabricate(:poll, account: account) }
  let!(:status) { Fabricate(:status, account: account, poll: poll) }

  before(:each) do
    @serialization = ActiveModelSerializers::SerializableResource.new(status, serializer: ActivityPub::UpdatePollSerializer, adapter: ActivityPub::Adapter)
  end

  subject { JSON.parse(@serialization.to_json) }

  it 'has a Update type' do
    expect(subject['type']).to eql('Update')
  end

  it 'has an object with Question type' do
    expect(subject['object']['type']).to eql('Question')
  end

  it 'has the correct actor URI set' do
    expect(subject['actor']).to eql(ActivityPub::TagManager.instance.uri_for(account))
  end
end

A spec/workers/activitypub/distribute_poll_update_worker_spec.rb => spec/workers/activitypub/distribute_poll_update_worker_spec.rb +22 -0
@@ 0,0 1,22 @@
require 'rails_helper'

describe ActivityPub::DistributePollUpdateWorker do
  subject { described_class.new }

  let(:account)  { Fabricate(:account) }
  let(:follower) { Fabricate(:account, protocol: :activitypub, inbox_url: 'http://example.com') }
  let(:poll)     { Fabricate(:poll, account: account) }
  let!(:status)  { Fabricate(:status, account: account, poll: poll) }

  describe '#perform' do
    before do
      allow(ActivityPub::DeliveryWorker).to receive(:push_bulk)
      follower.follow!(account)
    end

    it 'delivers to followers' do
      subject.perform(status.id)
      expect(ActivityPub::DeliveryWorker).to have_received(:push_bulk).with(['http://example.com'])
    end
  end
end