~cytrogen/masto-fe

d9a958fcf7c01462c1235895f0bde7b35c233f45 — Matt Jankowski 2 years ago b25860c
Fix Performance/RedundantMerge cop (#24817)

2 files changed, 2 insertions(+), 16 deletions(-)

M .rubocop_todo.yml
M config/initializers/paperclip.rb
M .rubocop_todo.yml => .rubocop_todo.yml +0 -6
@@ 310,12 310,6 @@ Performance/MapCompact:
    - 'spec/presenters/status_relationships_presenter_spec.rb'

# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge:
  Exclude:
    - 'config/initializers/paperclip.rb'

# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: SafeMultiline.
Performance/StartWith:
  Exclude:

M config/initializers/paperclip.rb => config/initializers/paperclip.rb +2 -10
@@ 68,11 68,7 @@ if ENV['S3_ENABLED'] == 'true'
    }
  )
  
  if ENV['S3_PERMISSION'] == ''
    Paperclip::Attachment.default_options.merge!(
      s3_permissions: ->(*) { nil }
    )
  end
  Paperclip::Attachment.default_options[:s3_permissions] = ->(*) { nil } if ENV['S3_PERMISSION'] == ''

  if ENV.has_key?('S3_ENDPOINT')
    Paperclip::Attachment.default_options[:s3_options].merge!(


@@ 90,11 86,7 @@ if ENV['S3_ENABLED'] == 'true'
    )
  end

  if ENV.has_key?('S3_STORAGE_CLASS')
    Paperclip::Attachment.default_options[:s3_headers].merge!(
      'X-Amz-Storage-Class' => ENV['S3_STORAGE_CLASS']
    )
  end
  Paperclip::Attachment.default_options[:s3_headers]['X-Amz-Storage-Class'] = ENV['S3_STORAGE_CLASS'] if ENV.has_key?('S3_STORAGE_CLASS')

  # Some S3-compatible providers might not actually be compatible with some APIs
  # used by kt-paperclip, see https://github.com/mastodon/mastodon/issues/16822