~cytrogen/gstack

ref: 4a77cc2c34506d9ce57193b3378e48e22b7b9842 gstack/test/fixtures/review-eval-enum-diff.rb -rw-r--r-- 986 bytes
4a77cc2c — Garry Tan feat: /plan-design-review + /qa-design-review skills (v0.5.0) (#102) a month ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
# Feature branch version: adds "returned" status but misses consumers
class Order < ApplicationRecord
  STATUSES = %w[pending processing shipped delivered returned].freeze

  validates :status, inclusion: { in: STATUSES }

  def display_status
    case status
    when 'pending'    then 'Awaiting processing'
    when 'processing' then 'Being prepared'
    when 'shipped'    then 'On the way'
    when 'delivered'  then 'Delivered'
    # BUG: 'returned' not handled — falls through to nil
    end
  end

  def can_cancel?
    # BUG: should 'returned' be cancellable? Not considered.
    %w[pending processing].include?(status)
  end

  def notify_customer
    case status
    when 'pending'    then OrderMailer.confirmation(self).deliver_later
    when 'shipped'    then OrderMailer.shipped(self).deliver_later
    when 'delivered'  then OrderMailer.delivered(self).deliver_later
    # BUG: 'returned' has no notification — customer won't know return was received
    end
  end
end