~cytrogen/gstack

ref: 66894601e3de98c0c3b32869944edc241484b42e gstack/browse/test/sidebar-integration.test.ts -rw-r--r-- 9.8 KiB
66894601 — Garry Tan chore: gitignore .factory and remove tracked files (v0.13.5.1) (#642) 11 days ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
/**
 * Layer 2: Server HTTP integration tests for sidebar endpoints.
 * Starts the browse server as a subprocess (no browser via BROWSE_HEADLESS_SKIP),
 * exercises sidebar HTTP endpoints with fetch(). No Chrome, no Claude, no sidebar-agent.
 */

import { describe, test, expect, beforeAll, afterAll, beforeEach } from 'bun:test';
import { spawn, type Subprocess } from 'bun';
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';

let serverProc: Subprocess | null = null;
let serverPort: number = 0;
let authToken: string = '';
let tmpDir: string = '';
let stateFile: string = '';
let queueFile: string = '';

async function api(pathname: string, opts: RequestInit & { noAuth?: boolean } = {}): Promise<Response> {
  const { noAuth, ...fetchOpts } = opts;
  const headers: Record<string, string> = {
    'Content-Type': 'application/json',
    ...(fetchOpts.headers as Record<string, string> || {}),
  };
  if (!noAuth && !headers['Authorization'] && authToken) {
    headers['Authorization'] = `Bearer ${authToken}`;
  }
  return fetch(`http://127.0.0.1:${serverPort}${pathname}`, { ...fetchOpts, headers });
}

beforeAll(async () => {
  tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'sidebar-integ-'));
  stateFile = path.join(tmpDir, 'browse.json');
  queueFile = path.join(tmpDir, 'sidebar-queue.jsonl');

  // Ensure queue dir exists
  fs.mkdirSync(path.dirname(queueFile), { recursive: true });

  const serverScript = path.resolve(__dirname, '..', 'src', 'server.ts');
  serverProc = spawn(['bun', 'run', serverScript], {
    env: {
      ...process.env,
      BROWSE_STATE_FILE: stateFile,
      BROWSE_HEADLESS_SKIP: '1',
      BROWSE_PORT: '0',
      SIDEBAR_QUEUE_PATH: queueFile,
      BROWSE_IDLE_TIMEOUT: '300',
    },
    stdio: ['ignore', 'pipe', 'pipe'],
  });

  // Wait for state file
  const deadline = Date.now() + 15000;
  while (Date.now() < deadline) {
    if (fs.existsSync(stateFile)) {
      try {
        const state = JSON.parse(fs.readFileSync(stateFile, 'utf-8'));
        if (state.port && state.token) {
          serverPort = state.port;
          authToken = state.token;
          break;
        }
      } catch {}
    }
    await new Promise(r => setTimeout(r, 100));
  }
  if (!serverPort) throw new Error('Server did not start in time');
}, 20000);

afterAll(() => {
  if (serverProc) { try { serverProc.kill(); } catch {} }
  try { fs.rmSync(tmpDir, { recursive: true, force: true }); } catch {}
});

// Reset state between tests — creates a fresh session, clears all queues
async function resetState() {
  await api('/sidebar-session/new', { method: 'POST' });
  fs.writeFileSync(queueFile, '');
}

describe('sidebar auth', () => {
  test('rejects request without auth token', async () => {
    const resp = await api('/sidebar-command', {
      method: 'POST',
      noAuth: true,
      body: JSON.stringify({ message: 'test' }),
    });
    expect(resp.status).toBe(401);
  });

  test('rejects request with wrong token', async () => {
    const resp = await api('/sidebar-command', {
      method: 'POST',
      headers: { 'Authorization': 'Bearer wrong-token' },
      body: JSON.stringify({ message: 'test' }),
    });
    expect(resp.status).toBe(401);
  });

  test('accepts request with correct token', async () => {
    const resp = await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'hello' }),
    });
    expect(resp.status).toBe(200);
    // Clean up
    await api('/sidebar-agent/kill', { method: 'POST' });
  });
});

describe('sidebar-command → queue', () => {
  test('writes queue entry with activeTabUrl', async () => {
    await resetState();

    const resp = await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({
        message: 'what is on this page?',
        activeTabUrl: 'https://example.com/test-page',
      }),
    });
    expect(resp.status).toBe(200);
    const data = await resp.json();
    expect(data.ok).toBe(true);

    // Give server a moment to write queue
    await new Promise(r => setTimeout(r, 100));

    const content = fs.readFileSync(queueFile, 'utf-8').trim();
    const lines = content.split('\n').filter(Boolean);
    expect(lines.length).toBeGreaterThan(0);
    const entry = JSON.parse(lines[lines.length - 1]);
    expect(entry.pageUrl).toBe('https://example.com/test-page');
    expect(entry.prompt).toContain('https://example.com/test-page');

    await api('/sidebar-agent/kill', { method: 'POST' });
  });

  test('falls back when activeTabUrl is null', async () => {
    await resetState();

    await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'test', activeTabUrl: null }),
    });
    await new Promise(r => setTimeout(r, 100));

    const lines = fs.readFileSync(queueFile, 'utf-8').trim().split('\n').filter(Boolean);
    expect(lines.length).toBeGreaterThan(0);
    const entry = JSON.parse(lines[lines.length - 1]);
    // No browser → playwright URL is 'about:blank'
    expect(entry.pageUrl).toBe('about:blank');

    await api('/sidebar-agent/kill', { method: 'POST' });
  });

  test('rejects chrome:// activeTabUrl and falls back', async () => {
    await resetState();

    await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'test', activeTabUrl: 'chrome://extensions' }),
    });
    await new Promise(r => setTimeout(r, 100));

    const lines = fs.readFileSync(queueFile, 'utf-8').trim().split('\n').filter(Boolean);
    expect(lines.length).toBeGreaterThan(0);
    const entry = JSON.parse(lines[lines.length - 1]);
    expect(entry.pageUrl).toBe('about:blank');

    await api('/sidebar-agent/kill', { method: 'POST' });
  });

  test('rejects empty message', async () => {
    const resp = await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: '' }),
    });
    expect(resp.status).toBe(400);
  });
});

describe('sidebar-agent/event → chat buffer', () => {
  test('agent events appear in /sidebar-chat', async () => {
    await resetState();

    // Post mock agent events using Claude's streaming format
    await api('/sidebar-agent/event', {
      method: 'POST',
      body: JSON.stringify({
        type: 'assistant',
        message: { content: [{ type: 'text', text: 'Hello from mock agent' }] },
      }),
    });

    const chatData = await (await api('/sidebar-chat?after=0')).json();
    const textEntry = chatData.entries.find((e: any) => e.type === 'text');
    expect(textEntry).toBeDefined();
    expect(textEntry.text).toBe('Hello from mock agent');
  });

  test('agent_done transitions status to idle', async () => {
    await resetState();
    // Start a command so agent is processing
    await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'test' }),
    });

    // Verify processing
    let session = await (await api('/sidebar-session')).json();
    expect(session.agent.status).toBe('processing');

    // Send agent_done
    await api('/sidebar-agent/event', {
      method: 'POST',
      body: JSON.stringify({ type: 'agent_done' }),
    });

    session = await (await api('/sidebar-session')).json();
    expect(session.agent.status).toBe('idle');
  });
});

describe('message queuing', () => {
  test('queues message when agent is processing', async () => {
    await resetState();

    // First message starts processing
    await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'first' }),
    });

    // Second message gets queued
    const resp = await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'second' }),
    });
    const data = await resp.json();
    expect(data.ok).toBe(true);
    expect(data.queued).toBe(true);
    expect(data.position).toBe(1);

    await api('/sidebar-agent/kill', { method: 'POST' });
  });

  test('returns 429 when queue is full', async () => {
    await resetState();

    // First message starts processing
    await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'first' }),
    });

    // Fill queue (max 5)
    for (let i = 0; i < 5; i++) {
      await api('/sidebar-command', {
        method: 'POST',
        body: JSON.stringify({ message: `fill-${i}` }),
      });
    }

    // 7th message should be rejected
    const resp = await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'overflow' }),
    });
    expect(resp.status).toBe(429);

    await api('/sidebar-agent/kill', { method: 'POST' });
  });
});

describe('chat clear', () => {
  test('clears chat buffer', async () => {
    await resetState();
    // Add some entries
    await api('/sidebar-agent/event', {
      method: 'POST',
      body: JSON.stringify({ type: 'text', text: 'to be cleared' }),
    });

    await api('/sidebar-chat/clear', { method: 'POST' });

    const data = await (await api('/sidebar-chat?after=0')).json();
    expect(data.entries.length).toBe(0);
    expect(data.total).toBe(0);
  });
});

describe('agent kill', () => {
  test('kill adds error entry and returns to idle', async () => {
    await resetState();

    // Start a command so agent is processing
    await api('/sidebar-command', {
      method: 'POST',
      body: JSON.stringify({ message: 'kill me' }),
    });

    let session = await (await api('/sidebar-session')).json();
    expect(session.agent.status).toBe('processing');

    // Kill the agent
    const killResp = await api('/sidebar-agent/kill', { method: 'POST' });
    expect(killResp.status).toBe(200);

    // Check chat for error entry
    const chatData = await (await api('/sidebar-chat?after=0')).json();
    const errorEntry = chatData.entries.find((e: any) => e.error === 'Killed by user');
    expect(errorEntry).toBeDefined();

    // Agent should be idle (no queue items to auto-process)
    session = await (await api('/sidebar-session')).json();
    expect(session.agent.status).toBe('idle');
  });
});