~cytrogen/gstack

ref: b2b380bfcc39107f9fdafc17e61bd74cc34fb537 gstack/test/learnings.test.ts -rw-r--r-- 12.0 KiB
b2b380bf — Garry Tan docs: update README and skill deep dives for all 31 skills (#656) 10 days ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
import { execSync, ExecSyncOptionsWithStringEncoding } from 'child_process';
import * as fs from 'fs';
import * as path from 'path';
import * as os from 'os';

const ROOT = path.resolve(import.meta.dir, '..');
const BIN = path.join(ROOT, 'bin');

let tmpDir: string;
let slugDir: string;
let learningsFile: string;

function runLog(input: string, opts: { expectFail?: boolean } = {}): { stdout: string; exitCode: number } {
  const execOpts: ExecSyncOptionsWithStringEncoding = {
    cwd: ROOT,
    env: { ...process.env, GSTACK_HOME: tmpDir },
    encoding: 'utf-8',
    timeout: 15000,
  };
  try {
    const stdout = execSync(`${BIN}/gstack-learnings-log '${input.replace(/'/g, "'\\''")}'`, execOpts).trim();
    return { stdout, exitCode: 0 };
  } catch (e: any) {
    if (opts.expectFail) {
      return { stdout: e.stderr?.toString() || '', exitCode: e.status || 1 };
    }
    throw e;
  }
}

function runSearch(args: string = ''): string {
  const execOpts: ExecSyncOptionsWithStringEncoding = {
    cwd: ROOT,
    env: { ...process.env, GSTACK_HOME: tmpDir },
    encoding: 'utf-8',
    timeout: 15000,
  };
  try {
    return execSync(`${BIN}/gstack-learnings-search ${args}`, execOpts).trim();
  } catch {
    return '';
  }
}

beforeEach(() => {
  tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-learn-'));
  slugDir = path.join(tmpDir, 'projects');
  fs.mkdirSync(slugDir, { recursive: true });
});

afterEach(() => {
  fs.rmSync(tmpDir, { recursive: true, force: true });
});

function findLearningsFile(): string | null {
  const projectDirs = fs.readdirSync(slugDir);
  if (projectDirs.length === 0) return null;
  const f = path.join(slugDir, projectDirs[0], 'learnings.jsonl');
  return fs.existsSync(f) ? f : null;
}

describe('gstack-learnings-log', () => {
  test('appends valid JSON to learnings.jsonl', () => {
    const input = '{"skill":"review","type":"pattern","key":"test-key","insight":"test insight","confidence":8,"source":"observed"}';
    const result = runLog(input);
    expect(result.exitCode).toBe(0);

    const f = findLearningsFile();
    expect(f).not.toBeNull();
    const content = fs.readFileSync(f!, 'utf-8').trim();
    const parsed = JSON.parse(content);
    expect(parsed.skill).toBe('review');
    expect(parsed.key).toBe('test-key');
    expect(parsed.confidence).toBe(8);
  });

  test('auto-injects timestamp when ts is missing', () => {
    const input = '{"skill":"review","type":"pattern","key":"ts-test","insight":"test","confidence":5,"source":"observed"}';
    runLog(input);

    const f = findLearningsFile();
    expect(f).not.toBeNull();
    const parsed = JSON.parse(fs.readFileSync(f!, 'utf-8').trim());
    expect(parsed.ts).toBeDefined();
    expect(new Date(parsed.ts).getTime()).toBeGreaterThan(0);
  });

  test('rejects non-JSON input with non-zero exit code', () => {
    const result = runLog('not json at all', { expectFail: true });
    expect(result.exitCode).not.toBe(0);
  });

  test('append-only: duplicate keys create multiple entries', () => {
    const input1 = '{"skill":"review","type":"pattern","key":"dup-key","insight":"first version","confidence":6,"source":"observed"}';
    const input2 = '{"skill":"review","type":"pattern","key":"dup-key","insight":"second version","confidence":8,"source":"observed"}';
    runLog(input1);
    runLog(input2);

    const f = findLearningsFile();
    expect(f).not.toBeNull();
    const lines = fs.readFileSync(f!, 'utf-8').trim().split('\n');
    expect(lines.length).toBe(2);
  });
});

describe('gstack-learnings-search', () => {
  test('returns empty and exits 0 when no learnings file exists', () => {
    const output = runSearch();
    expect(output).toBe('');
  });

  test('returns formatted output when learnings exist', () => {
    runLog('{"skill":"review","type":"pattern","key":"test-search","insight":"search test insight","confidence":7,"source":"observed"}');
    const output = runSearch();
    expect(output).toContain('LEARNINGS:');
    expect(output).toContain('test-search');
    expect(output).toContain('search test insight');
  });

  test('deduplicates entries by key+type (latest wins)', () => {
    const old = JSON.stringify({ skill: 'review', type: 'pattern', key: 'dedup-test', insight: 'old version', confidence: 5, source: 'observed', ts: '2026-01-01T00:00:00Z' });
    const newer = JSON.stringify({ skill: 'review', type: 'pattern', key: 'dedup-test', insight: 'new version', confidence: 8, source: 'observed', ts: '2026-03-28T00:00:00Z' });
    runLog(old);
    runLog(newer);

    const output = runSearch();
    expect(output).toContain('new version');
    expect(output).not.toContain('old version');
    expect(output).toContain('1 loaded');
  });

  test('filters by --type', () => {
    runLog('{"skill":"review","type":"pattern","key":"p1","insight":"a pattern","confidence":7,"source":"observed"}');
    runLog('{"skill":"review","type":"pitfall","key":"p2","insight":"a pitfall","confidence":7,"source":"observed"}');

    const patternOnly = runSearch('--type pattern');
    expect(patternOnly).toContain('p1');
    expect(patternOnly).not.toContain('p2');
  });

  test('filters by --query', () => {
    runLog('{"skill":"review","type":"pattern","key":"auth-bypass","insight":"check session tokens","confidence":7,"source":"observed"}');
    runLog('{"skill":"review","type":"pattern","key":"n-plus-one","insight":"use includes for associations","confidence":7,"source":"observed"}');

    const authOnly = runSearch('--query auth');
    expect(authOnly).toContain('auth-bypass');
    expect(authOnly).not.toContain('n-plus-one');
  });

  test('respects --limit', () => {
    for (let i = 0; i < 5; i++) {
      runLog(`{"skill":"review","type":"pattern","key":"limit-${i}","insight":"insight ${i}","confidence":7,"source":"observed"}`);
    }

    const limited = runSearch('--limit 2');
    // Should show 2, not 5
    expect(limited).toContain('2 loaded');
  });

  test('applies confidence decay for observed/inferred sources', () => {
    // Entry from 90 days ago with source=observed, confidence=8
    // Should decay to 8 - floor(90/30) = 8 - 3 = 5
    const ts = new Date(Date.now() - 90 * 86400000).toISOString();
    runLog(`{"skill":"review","type":"pattern","key":"decay-test","insight":"old observation","confidence":8,"source":"observed","ts":"${ts}"}`);

    const output = runSearch();
    // Should show confidence 5 (decayed from 8)
    expect(output).toContain('confidence: 5/10');
  });

  test('does NOT decay user-stated learnings', () => {
    const ts = new Date(Date.now() - 90 * 86400000).toISOString();
    runLog(`{"skill":"review","type":"preference","key":"no-decay-test","insight":"user preference","confidence":9,"source":"user-stated","ts":"${ts}"}`);

    const output = runSearch();
    // Should still show confidence 9 (no decay for user-stated)
    expect(output).toContain('confidence: 9/10');
  });

  test('skips malformed JSONL lines gracefully', () => {
    // Write a valid entry, then manually append a bad line
    runLog('{"skill":"review","type":"pattern","key":"valid-entry","insight":"valid","confidence":7,"source":"observed"}');
    const f = findLearningsFile();
    expect(f).not.toBeNull();
    fs.appendFileSync(f!, '\nthis is not json\n');
    fs.appendFileSync(f!, '{"skill":"review","type":"pattern","key":"also-valid","insight":"also valid","confidence":6,"source":"observed","ts":"2026-03-28T00:00:00Z"}\n');

    const output = runSearch();
    expect(output).toContain('valid-entry');
    expect(output).toContain('also-valid');
  });
});

describe('gstack-learnings-log edge cases', () => {
  test('preserves existing timestamp when ts is present', () => {
    const input = '{"skill":"review","type":"pattern","key":"ts-preserve","insight":"test","confidence":5,"source":"observed","ts":"2025-06-15T10:00:00Z"}';
    runLog(input);

    const f = findLearningsFile();
    expect(f).not.toBeNull();
    const parsed = JSON.parse(fs.readFileSync(f!, 'utf-8').trim());
    expect(parsed.ts).toBe('2025-06-15T10:00:00Z');
  });

  test('handles JSON with special characters in insight', () => {
    const input = JSON.stringify({ skill: 'review', type: 'pattern', key: 'special-chars', insight: 'Use "quotes" and \\backslashes', confidence: 7, source: 'observed' });
    runLog(input);

    const f = findLearningsFile();
    expect(f).not.toBeNull();
    const parsed = JSON.parse(fs.readFileSync(f!, 'utf-8').trim());
    expect(parsed.insight).toContain('quotes');
    expect(parsed.insight).toContain('backslashes');
  });

  test('handles JSON with files array field', () => {
    const input = JSON.stringify({ skill: 'review', type: 'architecture', key: 'with-files', insight: 'test', confidence: 8, source: 'observed', files: ['src/auth.ts', 'src/db.ts'] });
    runLog(input);

    const f = findLearningsFile();
    expect(f).not.toBeNull();
    const parsed = JSON.parse(fs.readFileSync(f!, 'utf-8').trim());
    expect(parsed.files).toEqual(['src/auth.ts', 'src/db.ts']);
  });
});

describe('gstack-learnings-search edge cases', () => {
  test('sorts by confidence then recency', () => {
    // Two entries: one high confidence old, one lower confidence recent
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'high-conf', insight: 'high confidence entry', confidence: 9, source: 'user-stated', ts: '2026-01-01T00:00:00Z' }));
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'recent', insight: 'recent entry', confidence: 5, source: 'observed', ts: '2026-03-28T00:00:00Z' }));

    const output = runSearch();
    const highIdx = output.indexOf('high-conf');
    const recentIdx = output.indexOf('recent');
    // High confidence should appear first
    expect(highIdx).toBeLessThan(recentIdx);
  });

  test('groups output by type', () => {
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'p1', insight: 'a pattern', confidence: 7, source: 'observed' }));
    runLog(JSON.stringify({ skill: 'review', type: 'pitfall', key: 'pit1', insight: 'a pitfall', confidence: 7, source: 'observed' }));

    const output = runSearch();
    expect(output).toContain('## Patterns');
    expect(output).toContain('## Pitfalls');
  });

  test('combined --type and --query filtering', () => {
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'auth-token', insight: 'check token expiry', confidence: 7, source: 'observed' }));
    runLog(JSON.stringify({ skill: 'review', type: 'pitfall', key: 'auth-leak', insight: 'auth token in logs', confidence: 7, source: 'observed' }));
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'cache-key', insight: 'cache invalidation', confidence: 7, source: 'observed' }));

    const output = runSearch('--type pattern --query auth');
    expect(output).toContain('auth-token');
    expect(output).not.toContain('auth-leak');  // wrong type
    expect(output).not.toContain('cache-key');  // wrong query
  });

  test('entries with missing key or type are skipped', () => {
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'valid', insight: 'valid entry', confidence: 7, source: 'observed' }));
    const f = findLearningsFile();
    expect(f).not.toBeNull();
    // Append entries missing key and type
    fs.appendFileSync(f!, JSON.stringify({ skill: 'review', type: 'pattern', insight: 'no key', confidence: 7, source: 'observed' }) + '\n');
    fs.appendFileSync(f!, JSON.stringify({ skill: 'review', key: 'no-type', insight: 'no type', confidence: 7, source: 'observed' }) + '\n');

    const output = runSearch();
    expect(output).toContain('valid');
    expect(output).not.toContain('no key');
    expect(output).not.toContain('no-type');
  });

  test('confidence decay floors at 0 (never negative)', () => {
    // Entry from 1 year ago with confidence 3 — decay would be 12, clamped to 0
    const ts = new Date(Date.now() - 365 * 86400000).toISOString();
    runLog(JSON.stringify({ skill: 'review', type: 'pattern', key: 'ancient', insight: 'very old', confidence: 3, source: 'observed', ts }));

    const output = runSearch();
    expect(output).toContain('confidence: 0/10');
  });
});