~cytrogen/masto-fe

ref: eba3411bfa40cbb36205f58a36e34c446fed0ffa masto-fe/spec/workers/move_worker_spec.rb -rw-r--r-- 7.7 KiB
eba3411b — Plastikmensch Re-allow title attribute in <abbr> (#2254) 2 years ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
# frozen_string_literal: true

require 'rails_helper'

describe MoveWorker do
  subject { described_class.new }

  let(:local_follower)   { Fabricate(:account, domain: nil) }
  let(:blocking_account) { Fabricate(:account) }
  let(:muting_account)   { Fabricate(:account) }
  let(:source_account)   { Fabricate(:account, protocol: :activitypub, domain: 'example.com', uri: 'https://example.org/a', inbox_url: 'https://example.org/a/inbox') }
  let(:target_account)   { Fabricate(:account, protocol: :activitypub, domain: 'example.com', uri: 'https://example.org/b', inbox_url: 'https://example.org/b/inbox') }
  let(:local_user)       { Fabricate(:user) }
  let(:comment)          { 'old note prior to move' }
  let!(:account_note)    { Fabricate(:account_note, account: local_user.account, target_account: source_account, comment: comment) }
  let(:list)             { Fabricate(:list, account: local_follower) }

  let(:block_service) { double }

  before do
    stub_request(:post, 'https://example.org/a/inbox').to_return(status: 200)
    stub_request(:post, 'https://example.org/b/inbox').to_return(status: 200)

    local_follower.follow!(source_account)
    blocking_account.block!(source_account)
    muting_account.mute!(source_account)

    list.accounts << source_account

    allow(BlockService).to receive(:new).and_return(block_service)
    allow(block_service).to receive(:call)
  end

  shared_examples 'user note handling' do
    context 'when user notes are short enough' do
      it 'copies user note with prelude' do
        subject.perform(source_account.id, target_account.id)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(source_account.acct)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(account_note.comment)
      end

      it 'merges user notes when needed' do
        new_account_note = AccountNote.create!(account: account_note.account, target_account: target_account, comment: 'new note prior to move')

        subject.perform(source_account.id, target_account.id)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(source_account.acct)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(account_note.comment)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(new_account_note.comment)
      end
    end

    context 'when user notes are too long' do
      let(:comment) { 'abc' * 333 }

      it 'copies user note without prelude' do
        subject.perform(source_account.id, target_account.id)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(account_note.comment)
      end

      it 'keeps user notes unchanged' do
        new_account_note = AccountNote.create!(account: account_note.account, target_account: target_account, comment: 'new note prior to move')

        subject.perform(source_account.id, target_account.id)
        expect(AccountNote.find_by(account: account_note.account, target_account: target_account).comment).to include(new_account_note.comment)
      end
    end
  end

  shared_examples 'block and mute handling' do
    it 'makes blocks carry over and add a note' do
      subject.perform(source_account.id, target_account.id)
      expect(block_service).to have_received(:call).with(blocking_account, target_account)
      expect(AccountNote.find_by(account: blocking_account, target_account: target_account).comment).to include(source_account.acct)
    end

    it 'makes mutes carry over and add a note' do
      subject.perform(source_account.id, target_account.id)
      expect(muting_account.muting?(target_account)).to be true
      expect(AccountNote.find_by(account: muting_account, target_account: target_account).comment).to include(source_account.acct)
    end
  end

  shared_examples 'followers count handling' do
    it 'updates the source account followers count' do
      subject.perform(source_account.id, target_account.id)
      expect(source_account.reload.followers_count).to eq(source_account.passive_relationships.count)
    end

    it 'updates the target account followers count' do
      subject.perform(source_account.id, target_account.id)
      expect(target_account.reload.followers_count).to eq(target_account.passive_relationships.count)
    end
  end

  shared_examples 'lists handling' do
    it 'puts the new account on the list' do
      subject.perform(source_account.id, target_account.id)
      expect(list.accounts.include?(target_account)).to be true
    end

    it 'does not create invalid list memberships' do
      subject.perform(source_account.id, target_account.id)
      expect(ListAccount.all).to all be_valid
    end
  end

  shared_examples 'common tests' do
    include_examples 'user note handling'
    include_examples 'block and mute handling'
    include_examples 'followers count handling'
    include_examples 'lists handling'

    context 'when a local user already follows both source and target' do
      before do
        local_follower.request_follow!(target_account)
      end

      include_examples 'user note handling'
      include_examples 'block and mute handling'
      include_examples 'followers count handling'
      include_examples 'lists handling'

      context 'when the local user already has the target in a list' do
        before do
          list.accounts << target_account
        end

        include_examples 'lists handling'
      end
    end

    context 'when a local follower already has a pending request to the target' do
      before do
        local_follower.follow!(target_account)
      end

      include_examples 'user note handling'
      include_examples 'block and mute handling'
      include_examples 'followers count handling'
      include_examples 'lists handling'

      context 'when the local user already has the target in a list' do
        before do
          list.accounts << target_account
        end

        include_examples 'lists handling'
      end
    end
  end

  describe '#perform' do
    context 'when both accounts are distant' do
      it 'calls UnfollowFollowWorker' do
        Sidekiq::Testing.fake! do
          subject.perform(source_account.id, target_account.id)
          expect(UnfollowFollowWorker).to have_enqueued_sidekiq_job(local_follower.id, source_account.id, target_account.id, false)
          Sidekiq::Worker.drain_all
        end
      end

      include_examples 'common tests'
    end

    context 'when target account is local' do
      let(:target_account) { Fabricate(:account) }

      it 'calls UnfollowFollowWorker' do
        Sidekiq::Testing.fake! do
          subject.perform(source_account.id, target_account.id)
          expect(UnfollowFollowWorker).to have_enqueued_sidekiq_job(local_follower.id, source_account.id, target_account.id, true)
          Sidekiq::Worker.clear_all
        end
      end

      include_examples 'common tests'
    end

    context 'when both target and source accounts are local' do
      let(:target_account) { Fabricate(:account) }
      let(:source_account) { Fabricate(:account) }

      it 'calls makes local followers follow the target account' do
        subject.perform(source_account.id, target_account.id)
        expect(local_follower.following?(target_account)).to be true
      end

      include_examples 'common tests'

      it 'does not allow the moved account to follow themselves' do
        source_account.follow!(target_account)
        subject.perform(source_account.id, target_account.id)
        expect(target_account.following?(target_account)).to be false
      end
    end
  end
end